Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKUs: log the return value of top level functions called from C++ #21543

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

evq
Copy link
Member

@evq evq commented Jan 10, 2024

per https://docs.rs/tracing/latest/tracing/attr.instrument.html, this will log the return value of these functions (INFO aka VLOG(2) on success, WARN aka VLOG(1) on failure.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@evq evq requested a review from a team as a code owner January 10, 2024 23:58
@evq
Copy link
Member Author

evq commented Jan 11, 2024

hm looks like this failed as we're using tracing 0.1.37, level = , we'll need to upgrade to 0.1.40 to use it ( though apparently added in 0.1.38, it and 0.1.39 were yanked. )

@evq evq requested a review from bridiver as a code owner January 11, 2024 11:18
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 11, 2024
@rillian
Copy link
Contributor

rillian commented Jan 11, 2024

though apparently added in 0.1.38, it and 0.1.39 were yanked.

Probably for use-after-free in Instrument::into_inner (which we don't call).

@evq evq requested a review from a team as a code owner January 11, 2024 20:34
Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evq
Copy link
Member Author

evq commented Jan 18, 2024

going foward with merge as CI failure is due to unrelated npm audit

@evq evq merged commit 4a1eae0 into master Jan 18, 2024
17 of 18 checks passed
@evq evq deleted the skus/log-return branch January 18, 2024 22:02
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants