Use OpenSSL 3.2 across all PHP versions #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
force-pushed
the
openssl-32
branch
from
8b89bd0
to
9ff4165
Compare
GrahamCampbell
force-pushed
the
openssl-32
branch
from
9ff4165
to
797c936
Compare
mnapoli
reviewed
Nov 24, 2023
| @@ -384,6 +385,10 @@ ARG VERSION_PHP | |||
| RUN curl --location --silent --show-error --fail https://www.php.net/get/php-${VERSION_PHP}.tar.gz/from/this/mirror \ | |||
| | tar xzC . --strip-components=1 | |||
|
|
|||
| COPY layers/openssl3.patch ${PHP_BUILD_DIR} | |||
| RUN patch -N -p1 -s < openssl3.patch | |||
| RUN rm openssl3.patch | |||
There was a problem hiding this comment.
As mentioned on Slack can you remove the patching for PHP 8.0?
My reasoning is:
- 8.0 is no longer maintained (even security fixes)
- this complicates the build
I'd rather keep things simple and keep 8.0 mostly for BC.
If you don't have time for this let me know, I can create a new PR based on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is OpenSSL 3.2 really a good idea - it's not LTS? NodeJS is using it in version 21 (and eventually in 22), so I guess so. We can also keep upgrading, through the 3.x series, so I don't see any major issues here. ;)
Fixes brefphp/bref#1528, maybe? We will need to confirm. I know there are additional fixes coming in 3.3, slated for release in 6-7 months from now.
Yes, I'm using a beta version of openssl - the stable 3.2.0 release is coming in the next few days, and the PR will be updated then.OpenSSL 3.2.0 is now released.