Added fieldnameprefix property #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| @@ -464,7 +464,7 @@ public void run() | |||
| rescode=cli.read("table1", key, s, result); | |||
| */ | |||
| HashSet<String> scanFields = new HashSet<String>(); | |||
| scanFields.add("field1"); | |||
| scanFields.add("field1"); //TODO: remove hardcoded field prefix | |||
There was a problem hiding this comment.
@gelin would it be possible to use the dynamic prefix field you added in the PR?
busbey
added a commit
to busbey/YCSB
that referenced
this pull request
Sep 9, 2018
Conflicts: core/src/main/java/com/yahoo/ycsb/workloads/CoreWorkload.java doc/coreproperties.html hbase/src/main/java/com/yahoo/ycsb/db/HBaseClient.java
busbey
added a commit
that referenced
this pull request
Nov 20, 2018
[core] Handle merge conflicts for #117 and update it for newer bindings that reference field name prefix
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default YCSB names the database record fields as “field” + a number.
The new configuration option allows to replace the “field” prefix with
something shorter which affects the data storage size for schema-less databases.