Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::error::Error for error types #3

Closed
wants to merge 1 commit into from
Closed

Implement std::error::Error for error types #3

wants to merge 1 commit into from

Conversation

frewsxcv
Copy link
Contributor

No description provided.

@frewsxcv
Copy link
Contributor Author

std::error::Error makes it easier for developers to to interpret errors if they ever arise. I feel like some of the descriptions within the strings are pretty sloppy, so if you have any suggestions, let me know and I'll change them.

@frewsxcv frewsxcv closed this Aug 28, 2015
@frewsxcv frewsxcv deleted the errors branch August 28, 2015 01:26
@Lukazoid
Copy link

Is there any particular reason this was never merged in?

@frewsxcv
Copy link
Contributor Author

IIRC, @briansmith has reservations about using the Error trait.

@briansmith briansmith mentioned this pull request Dec 4, 2020
Closed
bnoordhuis added a commit to bnoordhuis/webpki that referenced this pull request Sep 24, 2022
@bnoordhuis
Fix name constraints check
84928c6 
There were two bugs. webpki didn't:

1. read the X.509 Name Constraints field in its entirety, nor

2. check the certificate subject against the constraints correctly

(1) is a simple fix, (2) requires reading the Common Name from the
certificate.

Requires lifting some DER parsing logic from ring to parse UTF8String
and Set fields. Ring doesn't support those and isn't likely to in the
near future, see briansmith/ring#1265.

Closes briansmith#3.
bnoordhuis added a commit to bnoordhuis/webpki that referenced this pull request Nov 27, 2022
@bnoordhuis
Fix name constraints check
f4204bb 
There were two bugs. webpki didn't:

1. read the X.509 Name Constraints field in its entirety, nor

2. check the certificate subject against the constraints correctly

(1) is a simple fix, (2) requires reading the Common Name from the
certificate.

Requires lifting some DER parsing logic from ring to parse UTF8String
and Set fields. Ring doesn't support those and isn't likely to in the
near future, see briansmith/ring#1265.

Closes briansmith#3.
lufte pushed a commit to lufte/webpki that referenced this pull request Jan 25, 2023
@bnoordhuis @ctz
Fix name constraints check
53d7dc0 
There were two bugs. webpki didn't:

1. read the X.509 Name Constraints field in its entirety, nor

2. check the certificate subject against the constraints correctly

(1) is a simple fix, (2) requires reading the Common Name from the
certificate.

Requires lifting some DER parsing logic from ring to parse UTF8String
and Set fields. Ring doesn't support those and isn't likely to in the
near future, see briansmith/ring#1265.

Closes briansmith#3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frewsxcv @Lukazoid