Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to contribute with minor changes #12

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joanmarcriera
Copy link

Learning github for the first time.

@silviokennecke
Copy link

silviokennecke commented Feb 17, 2022

Hi @joanmarcriera, in this case, welcome to the world of open source projects 😊.
Contributions are normally always welcome. In some projects you find a CONTRIBUTE.md file in the root (sometimes also found in the README), with instructions for contributors.

One thing you should always try to keep in mind when creating a pr, is what should go in the title and description of it. If the changes refer to a ticket, the pr should reference it as well. Also, the title should give a short overview, what the pr is about. The description should then state what was changed and why. This way other developers can understand what you’re trying to solve more easily. Your pr can then be reviewed, approved and merged much faster.

It would be great if you could update your pr according to that, so other developers directly understand what this pr is about in scope of features, fixes, refactoring, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants