coerce.Pair: Deref union values (#4995)

Closes #4955
brimdata · Jan 18, 2024 · 144cc28 · 144cc28
1 parent 6875f96
commit 144cc28
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/runtime/expr/coerce/coerce.go b/runtime/expr/coerce/coerce.go
@@ -48,6 +48,7 @@ func (c *Pair) Equal() bool {
 }
 
 func (c *Pair) Coerce(a, b zed.Value) (int, error) {
+ a, b = a.Under(), b.Under()
  c.A = a.Bytes()
  c.B = b.Bytes()
  aid := a.Type().ID()

diff --git a/runtime/expr/expr_test.go b/runtime/expr/expr_test.go
@@ -355,6 +355,14 @@ func TestArithmetic(t *testing.T) {
  testSuccessful(t, "f / 1.25", record, "2.")
  testSuccessful(t, "5.0 / f", record, "2.")
 
+ // Union values are dereferenced when doing arithmetic on them.
+ val := "10((int64,string))"
+ testSuccessful(t, "this + 1", val, "11")
+ testSuccessful(t, "this - 1", val, "9")
+ testSuccessful(t, "this * 2", val, "20")
+ testSuccessful(t, "this / 2", val, "5")
+ testSuccessful(t, "this % 3", val, "1")
+
  // Difference of two times is a duration
  testSuccessful(t, "a - b", "{a:2022-09-22T00:00:01Z,b:2022-09-22T00:00:00Z}", "1s")