fix bug in spill file name allocation #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent refactor of the spill code into its own module introduced a bug where the file names could collide because they were named after their position in the spill table, which grows and shrinks. This caused distinct spills to have the same file name. The fix is to track the total number of spills and name the file after this.
nwt
approved these changes
Sep 29, 2020
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Sep 29, 2020
This is an auto-generated commit with a zq dependency update. The zq PR brimdata/super#1391, authored by @mccanne, has been merged. fix bug in spill file name allocation The recent refactor of the spill code into its own module introduced a bug where the file names could collide because they were named after their position in the spill table, which grows and shrinks. This caused distinct spills to have the same file name. The fix is to track the total number of spills and name the file after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactor of the spill code into its own module introduced
a bug where the file names could collide because they were named
after their position in the spill table, which grows and shrinks.
This caused distinct spills to have the same file name. The fix is
to track the total number of spills and name the file after this.