add a type alias for port when reading azng #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfred-landrum
force-pushed
the
azng-port-zcode
branch
from
925f29a
to
5f571bd
Compare
alfred-landrum
force-pushed
the
azng-port-zcode
branch
from
5f571bd
to
1212ee4
Compare
nwt
approved these changes
Oct 8, 2020
This was referenced Oct 8, 2020
Closed
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Oct 8, 2020
…fred-landrum This is an auto-generated commit with a zq dependency update. The zq PR brimdata/super#1441, authored by @alfred-landrum, has been merged. add a type alias for port when reading azng Recent Brim integration tests failures occurred because they were unable to read an alpha zng file that used the port type. This change automatically adds an alias for port -> uint16 whenever the azng reader is used, and adds a ztest with a more complex alpha zng file. While testing, I discovered the alpha tzngio writer was using the post-alpha zcode package, so I pulled in the alpha zcode package as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Brim integration tests failures occurred because they were unable to read an alpha zng file that used the port type. This change automatically adds an alias for port -> uint16 whenever the azng reader is used, and adds a ztest with a more complex alpha zng file.
While testing, I discovered the alpha tzngio writer was using the post-alpha zcode package, so I pulled in the alpha zcode package as well.