Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python zqd API client #1564

Merged
merged 9 commits into from
Nov 6, 2020
Merged

Add Python zqd API client #1564

merged 9 commits into from
Nov 6, 2020

Conversation

nwt
Copy link
Member

@nwt nwt commented Nov 5, 2020

Install this branch with pip install 'git+https:/brimsec/zq@python-zqd#subdirectory=python/zqd'.

After merge, install master with pip install 'git+https:/brimsec/zq#subdirectory=python/zqd'.

Closes #1519.

JupyterLab action shot:
image

@nwt nwt requested a review from a team November 5, 2020 01:29
@mattnibs
Copy link
Collaborator

mattnibs commented Nov 5, 2020

Can we get a test with this? I know it would be a pain, having said that it would be nice to know if an api change broke this.

@nwt
Copy link
Member Author

nwt commented Nov 5, 2020

@mattnibs: Added a test in c47bdb9.

@mccanne
Copy link
Collaborator

mccanne commented Nov 5, 2020

very slick!

python/zqd/zqd.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattnibs mattnibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alfred-landrum alfred-landrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned to noah on slack that we could add a note to the contributing file that we expect python3 to be available in the dev environment.

@nwt nwt merged commit 8d2a8d6 into master Nov 6, 2020
@nwt nwt deleted the python-zqd branch November 6, 2020 20:41
brim-bot pushed a commit to brimdata/zui that referenced this pull request Nov 6, 2020
This is an auto-generated commit with a zq dependency update. The zq PR
brimdata/super#1564, authored by @nwt,
has been merged.

Add Python zqd API client

Install this branch with `pip install 'git+https:/brimsec/zq@python-zqd#subdirectory=python/zqd'`.

After merge, install master with `pip install 'git+https:/brimsec/zq#subdirectory=python/zqd'`.

Closes brimdata/super#1519.

JupyterLab action shot:
![image](https://user-images.githubusercontent.com/2574448/98186143-f520fa80-1ec2-11eb-8126-06224f3a8880.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python zqd api client
4 participants