remove zio/ndjsonio.Reader in favor of zson.Reader #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zed shaping renders the typed NDJSON reader unnecessary. Replace it
with a zson.Reader and remove the following:
* api.LogPostRequest.JSONTypeeConfig (json_type_config request field
for /space/{space}/logs/paths)
* json_config form field for /space/{space}/log
* -j flag to zed query and zq
* zio.ReaderOpts.JSON
* zio/ndjsonio.Reader
* zsontypes command
mccanne
approved these changes
Apr 19, 2021
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Apr 19, 2021
…r" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/zed#2587, authored by @nwt, has been merged. remove zio/ndjsonio.Reader in favor of zson.Reader Zed shaping renders the typed NDJSON reader unnecessary. Replace it with a zson.Reader and remove the following: * api.LogPostRequest.JSONTypeeConfig (json_type_config request field for /space/{space}/logs/paths) * json_config form field for /space/{space}/log * -j flag to zed query and zq * zio.ReaderOpts.JSON * zio/ndjsonio.Reader * zsontypes command Closes brimdata/zed#2296. `zeek/README.md` needs an update; I've left that for @philrz.
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Apr 19, 2021
…r" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/zed#2587, authored by @nwt, has been merged. remove zio/ndjsonio.Reader in favor of zson.Reader Zed shaping renders the typed NDJSON reader unnecessary. Replace it with a zson.Reader and remove the following: * api.LogPostRequest.JSONTypeeConfig (json_type_config request field for /space/{space}/logs/paths) * json_config form field for /space/{space}/log * -j flag to zed query and zq * zio.ReaderOpts.JSON * zio/ndjsonio.Reader * zsontypes command Closes brimdata/zed#2296. `zeek/README.md` needs an update; I've left that for @philrz.
This was referenced Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zed shaping renders the typed NDJSON reader unnecessary. Replace it
with a zson.Reader and remove the following:
for /space/{space}/logs/paths)
Closes #2296.
zeek/README.mdneeds an update; I've left that for @philrz.