Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Writer: Allow different types in output #4889

Merged
merged 2 commits into from
Nov 22, 2023
Merged

CSV Writer: Allow different types in output #4889

merged 2 commits into from
Nov 22, 2023

Conversation

mattnibs
Copy link
Collaborator

Adjust the csvio.Writer so that it can handle records with the same field names but different types.

Closes #4781

@mattnibs mattnibs requested a review from a team November 17, 2023 22:15
@mattnibs mattnibs force-pushed the csv-less-fuse branch 4 times, most recently from 9269e8e to 2923261 Compare November 17, 2023 23:49
Adjust the csvio.Writer so that it can handle records with the same
field names but different types.

Closes #4781
@philrz
Copy link
Contributor

philrz commented Nov 21, 2023

I just tested out the branch at commit dc95dd8 and it seems to work great for the examples from #4781. That makes it a functional 👍 for me!

zio/csvio/writer.go Outdated Show resolved Hide resolved
Co-authored-by: Noah Treuhaft <[email protected]>
@mattnibs mattnibs merged commit 6d8abb5 into main Nov 22, 2023
3 checks passed
@mattnibs mattnibs deleted the csv-less-fuse branch November 22, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow CSV output when columns are consistent even if types aren't
3 participants