Add ability to cast to type #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Jan 11, 2024
runtime/expr/ztests/cast-type.yaml
Outdated
Comment on lines
1
to
15
| zed: 'yield type(this)' | ||
|
|
||
| input: | | ||
| "<int64>" | ||
| "<{x:string}>" | ||
| "1" | ||
| 1. | ||
|
|
||
| output: | | ||
| <int64> | ||
| <{x:string}> | ||
| error({message:"cannot cast to type",on:"1"}) | ||
| error({message:"cannot cast to type",on:1.}) |
There was a problem hiding this comment.
Put these tests in TestCasts in runtime/expr/expr_test.go so they're with the bulk of the other cast tests.
There was a problem hiding this comment.
I actually think it's toss up between whether there are more cast tests in expr_test or in the ztests directory. Personally I think its easier to find tests if they're ztests rather than buried in go tests. I kind of rather see that we move the tests in expr_test into ztests.
There was a problem hiding this comment.
I agree. Much prefer ztests and remember fighting expr_test when we made changes. At some point we should have a better way to ztest lots of different combos of things in one file.
nwt
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4714