Allow pools to be given a ksuid name #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
pool-ksuid-name
branch
from
758bbf2
to
8921233
Compare
The commit fixes an issue with pool looks that made it so pools with a ksuid-like name could not be looked up for most zed commands. Fix the logic for lake/api.PoolID so that looking up a pool by ID is tried first and then falls back to looking up a pool by name if nothing is found. Closes #4431
mattnibs
force-pushed
the
pool-ksuid-name
branch
from
8921233
to
bd4893b
Compare
mattnibs
force-pushed
the
pool-ksuid-name
branch
from
5bc14d8
to
449763b
Compare
nwt
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit fixes an issue with pool looks that made it so pools with a ksuid-like name could not be looked up for most zed commands. Fix the logic for lake/api.PoolID so that looking up a pool by ID is tried first and then falls back to looking up a pool by name if nothing is found.
Closes #4431
Closes #4828