Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Name collisions with uniq, head, top ops #5161

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Jul 1, 2024

This commit fix an issue with the parser where yield-less calling a functions named uniq, head, top would result in a parser error.

Closes #5160

Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does pass need the same treatment?

@mattnibs
Copy link
Collaborator Author

mattnibs commented Jul 1, 2024

Does pass need the same treatment?

Good call

This commit fix an issue with the parser where calling a functions named
uniq, head, top in an implied operator would result in a parser error.

Closes #5160
@mattnibs mattnibs merged commit 6f72a13 into main Jul 1, 2024
3 checks passed
@mattnibs mattnibs deleted the no-arg-ops branch July 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible parser error if user-defined op or func starts with an internal operator name
2 participants