Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unset pool error #5198

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Improve unset pool error #5198

merged 1 commit into from
Jul 31, 2024

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Jul 31, 2024

Closes #3309

@mattnibs mattnibs merged commit 57a04bd into main Jul 31, 2024
3 checks passed
@mattnibs mattnibs deleted the improve-unset-use-error branch July 31, 2024 17:31
@philrz
Copy link
Contributor

philrz commented Aug 7, 2024

This enhancement was in reaction to a user's experience in a community Slack thread. In their own words:

zed log isn’t working for me right now … dunno if I’m just missing something or what. I’ve tried a couple of things to troubleshoot this … (still on 1.16.0)

❯ zed init lake
lake created: file:///Users/chrismo/dev/ds6/ops/platform/aws/tf/kms/lake

❯ export ZED_LAKE=lake

❯ zed create keys
pool created: keys 2k157GhxTaVVMCOc0YGjaxgacMN

❯ aws kms list-keys --profile staging --region us-east-2 | zq -z 'over this.Keys' - | zed load -use keys -
(11/1) 792B 792B/s
2k158CfFyGJfCBFlwsXNAKFPwhf committed

❯ zed log        
empty pool and branch

They were informed of the role of zed use here and that got them up and running. But their experience did highlight that the error message could be improved to help new users bumping into this for the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve errors for failed "zapi load"
3 participants