A modal dialog experiment #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this error is related to the changes. |
mason-fish
approved these changes
Oct 28, 2020
|
|
||
| return ReactDOM.createPortal( | ||
| <Overlay> | ||
| <CSSTransition |
There was a problem hiding this comment.
Awesome, excited to get away from the anime lib and use this one more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an experiment for a new way to structure our modals. The goal is to give them more flexibility, while making it easy to still look consistent.
As part of the experiment, I re-did the "Debug Query" modal to use this new "ModalDialog" component. It has an enter and exit animation using CSSTransition, it pops down below the tab bar, it has a "Scrollable" container for content that can get very long, it has a footer component for the row of buttons, and it locks the rest of the screen using "pointer-events: none" on the body element when it's opened.