Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for No Windows when Migrating Queries #1387

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Jan 26, 2021

fixes #1386

This edit's an existing migration. Since migrations don't go backwards, you'll need to clear you app state, open v0.22.0, then save the state with no windows, then upgrade to v0.23.0 and see that the query library is populated.

Copy link
Contributor

@mason-fish mason-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a local .dmg installer and repeated the repro steps from #1386 and the Query Library was still there after relaunch. 👍

@jameskerr jameskerr merged commit 1e67547 into master Jan 26, 2021
@jameskerr jameskerr deleted the init_query_lib branch January 26, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Library lost upon upgrade due to migration issue
3 participants