Color consolidation #1405
Merged
Color consolidation #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-fish
approved these changes
Feb 2, 2021
| } | ||
| .port { | ||
| background: $green-light; | ||
| background: #5ec4a8; |
There was a problem hiding this comment.
Do we not want to capture this (and all of the zeek log type colors for that matter) in more centralized variables as well?
There was a problem hiding this comment.
Good point. The Zeek log type colors are mostly centralized in this file: https:/brimsec/brim/pull/1405/files#diff-6764dbaa5ca14068a22c350c9eea02ca7e3848ccdcfee72e8b1348a48ac5333d
The reason I didn't make this light green a variable is because I'm planning on re-doing that ConnVersation component at some point soon. It doesn't really fit the new detail pane width anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all the old colors we wanted to migrate away from. In the process, found tons of dead css from components that don't exist anymore and removed them.
Also, changed some of the color values to have a bit more blue hue to them.
The only color vars that should be present are defined in colors.scss with css variables at the :root level. Usage should be
var(--aqua)in all cases (Styled Components, JS, SCSS)