Missing workspace bug #1533
Merged
Missing workspace bug #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-fish
approved these changes
Mar 24, 2021
| @@ -21,6 +21,12 @@ const SpinnerWrap = styled.div` | |||
| justify-content: center; | |||
| ` | |||
|
|
|||
| function GetWorkspace({children}) { | |||
| const workspace = useSelector(Current.getWorkspace) | |||
| if (!workspace) return <Redirect to="/workspaces" /> | |||
jameskerr
force-pushed
the
missing-workspace-bug
branch
from
9ee8884
to
fa3fd86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a global function called
navTo(path). You can use this in the dev tools to go to a specific url.If you open the dev tools and type
navTo("/workspaces/does-not-exist"), then you will reproduce the bug reported at #1529.A simple null check fixed it. An integration test has been added to check for this now.
closes #1529