Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail formats #1643

Merged
merged 4 commits into from
May 17, 2021
Merged

Detail formats #1643

merged 4 commits into from
May 17, 2021

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented May 14, 2021

Fixes #1642

  • Removes commas from ports.
  • Formats time the same way in the detail window and the search window.
  • Adds type colors to the detail pane in both windows.

Screen Shot 2021-05-14 at 12 10 22 PM

image

@jameskerr jameskerr requested a review from mason-fish May 14, 2021 19:11
@jameskerr
Copy link
Member Author

Side fix: I moved the notifications (toasts) to be anchored on the bottom right of the page. I think this is a better place because the "menu" buttons and the "close buttons" are positioned on the right and will not be moving around if the width of the notification needs to change as it updates.

@@ -28,7 +28,7 @@ const BrimToaster = () => {
<>
<HiddenToast {...toastLocator.props}>{lastToast?.message}</HiddenToast>
<Toaster
position="bottom-center"
position="bottom-right"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jameskerr jameskerr merged commit 4ea31e1 into main May 17, 2021
@jameskerr jameskerr deleted the detail-formats branch May 17, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp in Log Detail lacks precision & doesn't reflect Preferences
2 participants