Release notes bug #1679
Merged
Release notes bug #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An ipc call mistakenly made its way into the Launches reducer. The reducer is run in both the main and the renderer process, because it is global. When the ipc was called on the main process, there was an error. It would be good to also find a way to surface these errors more.
jameskerr
commented
May 24, 2021
| @@ -10,9 +10,8 @@ const slice = createSlice({ | |||
| name: "$Launches", | |||
| initialState: {}, | |||
| reducers: { | |||
| touchVersion: (state, action: PayloadAction<string | undefined>) => { | |||
| let key = action.payload || getVersion() | |||
There was a problem hiding this comment.
This getVersion() call was what was causing the error. It makes a sync ipc call to the 'main' process. But this code was being run in the "main" process.
mattnibs
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1677
An ipc call mistakenly made its way into the Launches reducer. The
reducer is run in both the main and the renderer process, because
it is global. When the ipc was called on the main process, there
was an error.
The error was being thrown in the console:
This caused the "last-launched" state to never be saved.