Provide explicit values to the pool search url #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no span params are provided, all the components will implicitly use the pool defaults (saved in redux). When new commits arrive, the pool span will change. This results in some of the UI re-rendering even though the url has not changed. The only case we want this re-rendering behavior is when we are dragging a pcap into the app. Then we want to have an empty span and rely on the updating defaults. (although this feels confusing and worthy of simplifying) By being explicit with the spanArgs in the url, we can ensure that the UI will not re-render when the span of the pool changes in redux. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch more-data-bug # Changes to be committed: # modified: app/summary/home.tsx #
mason-fish
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no span params are provided, all the components will
implicitly use the pool defaults (saved in redux).
When new commits arrive, the
pool span will change. This results in
some of the UI re-rendering even though the url has not changed.
The only case we want this re-rendering behavior is when we are
dragging a pcap into the app. Then we want to have an empty span
and rely on the updating defaults. (although this feels confusing and
worthy of simplifying)
By being explicit with the spanArgs in the url, we can ensure that
the UI will not re-render when the span of the pool changes in redux.
fixes #1727