Give the typedefs to the field encoder #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
commented
Aug 26, 2021
| @@ -219,7 +219,8 @@ export class ZedContext { | |||
| const type = this.lookupTypeRecord([ | |||
| {name: field.name, type: field.value.type} | |||
| ]) | |||
| const transport = type.create([field.value.serialize()], {}) | |||
|
|
|||
| const transport = type.create([field.value.serialize()], {...this.typeById}) | |||
There was a problem hiding this comment.
@mccanne When I encode a single field into zjson (something only done in the app), I create a new record type with that single field, then encode that record. When I use that type to create the record value, I wasn't passing in anything for the typedefs argument. This led to a bug where if a field had a type value, like the string "conn"", it would not find the typedef and get encoded as "null".
I now pass in the typesById object which has all the types in the context. This works, but I want to make sure that it looks right to you too.
mason-fish
approved these changes
Aug 26, 2021
|
Thanks @mason-fish, I just made the tests even more robust by iterating over each record and each field, then encoding it, decoding it, and checking agains the original. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1795
The encoding and decoding of a field with a type value was not working correctly. Now we give it all the types in the context when encoding.