Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interact with the editor correctly #2836

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Interact with the editor correctly #2836

merged 1 commit into from
Aug 9, 2023

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Aug 9, 2023 •
edited
Loading

We just needed to target and fill in the new editor slightly differently.

@jameskerr jameskerr requested a review from philrz August 9, 2023 18:02
philrz
philrz approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated, but I happened to notice this in the GitHub interface if you want to give it a look and maybe shut off the noise.

image

@jameskerr
Copy link
Member Author

Yeah, I'll fix that soon.

@jameskerr jameskerr merged commit 37a88de into main Aug 9, 2023
3 checks passed
@jameskerr jameskerr deleted the fix-e2e-specs branch August 9, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameskerr @philrz