Update Electron #2934
Merged
Update Electron #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jameskerr
commented
Dec 20, 2023
•
jameskerr
commented
- Update Electron To Latest
- Update playwright to @next until 1.41 is released
- Simplify playwright invocations
jameskerr
commented
Dec 21, 2023
| })) as MainObject | ||
| expect(appMain.lake.start).toHaveBeenCalledTimes(1) | ||
| }) | ||
|
|
There was a problem hiding this comment.
This test was causing problems and is not necessary. If the lake doesn't start, many many other tests will fail.
jameskerr
commented
Dec 21, 2023
| @@ -49,14 +49,13 @@ export const buildAndAuthenticateLake = | |||
| return [false, null] | |||
| } | |||
|
|
|||
| const dialogOpts = { | |||
| const dialogChoice = await showMessageBox({ | |||
There was a problem hiding this comment.
TypeScript liked this better.
philrz
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.