Pin Playwright dependencies to 1.43.1 #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brainstorming ideas of how to address #3063, one idea @jameskerr thought of was to upgrade to the latest Playwright release. Alas, in my testing with this branch it didn't improve on the failure rate of the symptom reproduced using the looped test in #3063 (30 successes and 8 failures before I stopped it, to be precise). But I also confirmed that the e2e tests can all pass successfully using this newer version, so since that much checks out I figure it probably doesn't hurt to upgrade just in case it helps us avoid some other problem down the road or gives us access to a new feature we didn't know we wanted.