Advance to Electron 30.0.5 to get fix for electron#41839 #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
changed the title
philrz
changed the title
jameskerr
approved these changes
Jun 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3089, which has all the background.
Here I'm just advancing the Electron dependency to
30.0.5so we can have the benefit of the fix to electron/electron#41839. I see there's an Electron31.0.0release also available, but since jumping to a major release is how we bumped into this bug in the first place, and I hope to put out a Zui release very soon and hence am nervous about hitting new bugs, I'm going the conservative route of jumping only as far as we need to get things working again.Here's the proof of the fix being effective when I'm maximizing the window while running this branch at commit cbccd1b.
Demo.mp4