Handle zed.Union types in format.ts #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #3103 made it possible to smuggle a
nullunion value into the Detail output formatter that was not prepared to handle them. After walking the code with @jameskerr, his suggestion was to back out the change from #3103 and instead add code in the Detail output formatter to handle unions in a way that's tolerant ofnullvalues. The attached video shows the fix working as intended with this PR's branch at commit 7807deb.Demo.mp4
As it turns out, @jameskerr already had work underway to sunset this particular code in the Detail view in favor of what we do with Inspector, and he's already confirmed that new code is immune to this problem. However, since we took the time to fully understand what's wrong here, I figure it doesn't hurt to fix it so we're leaving the code in better shape as we lay it to rest, plus it'll let the #3117 community user work off a Zui Insiders release with the fix in the days leading up to the next GA Zui release.
Fixes #3117