PROD-1698 Download Errors with Spaces in Spaces #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The browser fetch api does this for us, but the node http.request module that we use here does not. One more reason for switching soon to the zealot client completly.
brim-bot
pushed a commit
that referenced
this pull request
May 20, 2020
…attnibs This is an auto-generated commit with a zq dependency update. The zq PR brimdata/zed#802, authored by @mattnibs, has been merged. Initial commit of zapi cli with info command Adds a barebones version of zapi: A simple cli for interacting with zqd servers. To reduce burden on reviewers the scope has been limited to and single command: info (additionally the stock charm help command also works). Future functionality will eventually cover the entirety of the zqd api including the ability to create, update, remove, post data to spaces. The info commands allows user to view information on space(s). The space(s) can be queried by using either the global space selection flags (i.e. -n or -id) or by use one or more globbed enhanced arguments. part of #526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I caught an exception that was not being handled so that if an error occurs in the same place, it will at least be shown in the UI.
Then I fixed the error that was throwing that exception. It turns out that the node http module does not encode the URI components that we pass to it. This must be done ourselves. By contrast, the browser fetch API encodes for us.
SIDE DISCOVERY
I also discovered some code on stack overflow that will allow us to use the browser fetch API and stream the response to the node fs module which writes to the file system. When we implement the packet download api call in zealot, I recommend doing this.
https://stackoverflow.com/a/44695617/3499804