PROD-1694 Store pcap slices in temp dir #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesbrown
reviewed
Apr 1, 2020
| @@ -276,8 +275,6 @@ export const waitUntilDownloadFinished = async (app: Application) => | |||
| ) | |||
| }) | |||
|
|
|||
| export const pcapsDir = () => downloadsDir() | |||
There was a problem hiding this comment.
Yeah this is fine we'll come up with another way to handle this.
mikesbrown
approved these changes
Apr 1, 2020
mason-fish
approved these changes
Apr 1, 2020
|
Since the failing CI step relates to the node_modules cache service being unavailable, I'm gonna merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the downloads directory, use
app.getPath("temp)which gets a temp directory in a platform specific way.I've verified this works and keeps the downloads directory clean. It is also possible to "Save As" in wireshark if a particular slice is interesting.