Throttle key events #670
Merged
Throttle key events #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Fish <[email protected]>
mason-fish
commented
Apr 22, 2020
| throttle((e) => { | ||
| e.preventDefault() | ||
| dispatch(adjustSelectedLogIndex(1)) | ||
| }, 200) |
There was a problem hiding this comment.
I experimented w a few values here, this seemed to be the fastest that my computer could handle without any odd glitching, and it still feels plenty fast to me
jameskerr
approved these changes
Apr 22, 2020
| }, 200) | ||
| ) | ||
| Mousetrap.bind("mod+t", () => dispatch(Tabs.new())) | ||
| Mousetrap.bind("mod+w", (e) => { |
There was a problem hiding this comment.
🙇♂️ Thank you! That had been bothering me so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #591
I also had noticed that
cmd+wwas closing the whole window instead of just the tab, so fixed that too (prevent default)Signed-off-by: Mason Fish [email protected]