Display Ingest Warnings #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-fish
approved these changes
Apr 24, 2020
| @@ -23,7 +23,8 @@ module.exports = { | |||
| "isEqual", | |||
| "isEmpty", | |||
| "every", | |||
| "kebabCase" | |||
| "kebabCase", | |||
| "camelCase" | |||
There was a problem hiding this comment.
what's this addition for?
There was a problem hiding this comment.
This is because the importjs tool I use to auto-import modules doesn't know about the named exports of lodash. So I've been slowly adding them. This must have been for a different branch that stuck in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576
Fixes #577
When we receive ingest warnings, we'll display a little warning counter at the bottom of the status bar. When clicked, it will open up a modal that contains the actual errors.
Here are pictures of the various states:
No Warnings
Finished ingesting with one warning
Modal (appears when counter is clicked)
If no logs were ingested and there were warnings