Yf collect duplicate metrics #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2019 15:35
…y been duplicate-marked. - includes some refactoring to avoid code duplication. - added license to files that were missing it - testing using the full MarkDuplicates testing suite.
added 2 commits
November 11, 2019 22:14
gbggrant
approved these changes
Nov 18, 2019
| @@ -158,13 +158,12 @@ | |||
| * | |||
| * @param libraryIdGenerator | |||
| */ | |||
| protected void finalizeAndWriteMetrics(final LibraryIdGenerator libraryIdGenerator) { | |||
| static public void finalizeAndWriteMetrics(final LibraryIdGenerator libraryIdGenerator, final MetricsFile<DuplicationMetrics, Double> file, final File metricsFile) { | |||
There was a problem hiding this comment.
Could you rename 'file' with a more informative name?
| * | ||
| */ | ||
| @CommandLineProgramProperties( | ||
| summary = CollectDuplicateMetrics.USAGE_SUMMARY + CollectDuplicateMetrics.USAGE_DETAILS, |
There was a problem hiding this comment.
Probably should put some whitespace between USAGE_SUMMARY and USAGE_DETAIL here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CLP to collect MarkDuplicate Metrics on a file that already has had its duplicate marked. Useful when you want to have the duplicate metrics of a file but do not want to re-preprocess it. Does NOT calculate OPTICAL_DUPLICATES.
Description
Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https:/broadinstitute/picard/wiki/Guidelines-for-pull-requests