Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for corrupted CO tag issue #1461

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix for corrupted CO tag issue #1461

merged 2 commits into from
May 14, 2020

Conversation

lbergelson
Copy link
Member

  • Someone on the forum reported an issue with a bam tag that was a long string instead of 2 characters. This is a fix, but not a test because i'm not sure how to build a bam that triggers isContaminant.

Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https:/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@pshapiro4broad pshapiro4broad self-assigned this May 13, 2020
lbergelson and others added 2 commits May 13, 2020 17:27
* Someone on the forum reported an issue with a bam tag that was a long string instead of 2 characters.  This is a fix, but not a test because i'm not sure how to build a bam that triggers isContaminant.
@lbergelson
Copy link
Member Author

@pshapiro4broad I updated it to master and now it's failing with:

Gradle suite > Gradle test > picard.vcf.UpdateVcfSequenceDictionaryTest > testUpdateVcfSequenceDictionary[2](/dev/stdout) FAILED
    java.lang.IllegalArgumentException: Output format type is not set, or could not be inferred from the output path. If a path was used, does it have a valid VCF extension (.vcf, .vcf.gz, .bcf)?
        at htsjdk.variant.variantcontext.writer.VariantContextWriterBuilder.build(VariantContextWriterBuilder.java:462)
        at htsjdk.variant.variantcontext.writer.VariantContextWriterBuilder.build(VariantContextWriterBuilder.java:415)
        at picard.vcf.UpdateVcfSequenceDictionary.doWork(UpdateVcfSequenceDictionary.java:89)
        at picard.cmdline.CommandLineProgram.instanceMain(CommandLineProgram.java:305)
        at picard.vcf.UpdateVcfSequenceDictionaryTest.testUpdateVcfSequenceDictionary(UpdateVcfSequenceDictionaryTest.java:105)
Finished 4700 tests

Not sure what that's about. Rebased it again to be sure and pushing, maybe it's just something transient.

@lbergelson
Copy link
Member Author

Seems to be fixed. Will merged once this all passes.

@lbergelson lbergelson merged commit 2cd1aac into master May 14, 2020
@lbergelson lbergelson deleted the lb_fix_for_CO_tag branch May 14, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants