Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1543

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Update README.md #1543

merged 3 commits into from
Jul 15, 2020

Conversation

yfarjoun
Copy link
Contributor

Add a pointer to the GATK website

Description

Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https:/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@yfarjoun yfarjoun requested a review from lbergelson July 12, 2020 02:23
Copy link
Contributor

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Hopefully this will help.

README.md Outdated
***User Support:***


For user questions please look for answers and ask first in the GATK forum: https://gatk.broadinstitute.org/hc/en-us
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link directly to the forum instead of the splash page? https://gatk.broadinstitute.org/hc/en-us/community/topics

Also, do we want to have the link destination visible or just a link on GATK forum? That seems more inline with the rest of the readme.

Suggested change
For user questions please look for answers and ask first in the GATK forum: https://gatk.broadinstitute.org/hc/en-us
For user questions please look for answers and ask first in the [GATK forum](https://gatk.broadinstitute.org/hc/en-us).

@yfarjoun
Copy link
Contributor Author

yfarjoun commented Jul 14, 2020

good point @lbergelson look again?

@yfarjoun yfarjoun merged commit 95c87e7 into master Jul 15, 2020
@yfarjoun yfarjoun deleted the yfarjoun-patch-1 branch July 15, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants