Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward verbosity flags to set-status #279

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

grembo
Copy link
Collaborator

@grembo grembo commented Nov 30, 2023

This gives the set-status call its own function in common,
improving readability.

@grembo grembo force-pushed the relay-verbose-flag-to-set-status branch from 8243cd1 to 878f5f4 Compare November 30, 2023 20:34
@grembo grembo requested a review from pizzamig December 1, 2023 17:34
@grembo grembo requested a review from hny-gd December 13, 2023 11:03
@grembo
Copy link
Collaborator Author

grembo commented Dec 13, 2023

@bretton Could you take a look at that? (it works fine in production for us)

@bretton
Copy link

bretton commented Dec 13, 2023

@bretton Could you take a look at that? (it works fine in production for us)

using this playbook for sample environment with inventory.five/hosts configured for LAN-hosted pot images, and the following secret developer settings enabled, I am able to build an environment:

# developer
pot_update_from_github=1
pot_git_repo=https:/bsdpot/pot.git
patch_pot=1
pull_request_id=279

Not sure what I'm checking, everything is working.

@grembo
Copy link
Collaborator Author

grembo commented Dec 13, 2023

@bretton I thought more of looking at the code, if time permits :)

@bretton
Copy link

bretton commented Dec 13, 2023

@bretton I thought more of looking at the code, if time permits :)

It's definitely easier to read some lines now. I don't have any input on the function.

Copy link
Collaborator

@pizzamig pizzamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is not a blocker, just a minor improvement.
What do you think of an entry in the changelog?

share/pot/common.sh Outdated Show resolved Hide resolved
This gives the set-status call its own function
in common, improving readability.
@grembo grembo force-pushed the relay-verbose-flag-to-set-status branch from 878f5f4 to 490d7ce Compare December 16, 2023 14:41
@grembo grembo merged commit c5a8ec4 into bsdpot:master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants