-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Buefy
to v0.9.28
#151
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 2 2
Lines 20 20
Branches 5 5
=======================================
Hits 18 18
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
You could bump the Nuxt versions to 2.17.3 and the other dev deps as well - to stay updated :) |
Note: the force push was to amend the commit |
The version is not updated yet in the NPM - can you publish it there? |
@miroslavgeorgiev @wesdevpro GitHub Actions workflow for publishing npm package failed with:
There is something wrong with I found dependencies related to
Since the requirement for |
- Fixes the problem that `npm ci` failed due to version mismatch of `buffer`. `buffer` older than required in `peerDependencies` of one dependency was installed because `peerDependencies` does not impose installation of the package. Explicitly installs `buffer^6.0.3` to resolve the issue. See the following comment for more details: buefy#151 (comment)
This is really strange.
As we've followed the same strategy as you:
So I checked the master branch here:
I can create a PR for you to check |
@miroslavgeorgiev Thank you for investigating the error. I tried Node v20.x:
We worked around the issue by explicitly installing |
It is working now, so thank you too :) |
Proposed Changes
Buefy
fornuxt-buefy
to the latest version ofv0.9.28
nuxt-buefy
tov0.4.28
As requested here: buefy/buefy#4011