Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Buefy to v0.9.28 #151

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Bump Buefy to v0.9.28 #151

merged 2 commits into from
Feb 13, 2024

Conversation

wesdevpro
Copy link
Member

Proposed Changes

  • Update Buefy for nuxt-buefy to the latest version of v0.9.28
  • Bump the minor version of nuxt-buefy to v0.4.28

As requested here: buefy/buefy#4011

@wesdevpro wesdevpro added the enhancement New feature or request label Feb 12, 2024
@wesdevpro wesdevpro self-assigned this Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a33bcb3) 90.00% compared to head (5d8a2d9) 90.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files           2        2           
  Lines          20       20           
  Branches        5        5           
=======================================
  Hits           18       18           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kikuomax kikuomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mirocklez
Copy link

You could bump the Nuxt versions to 2.17.3 and the other dev deps as well - to stay updated :)

@wesdevpro
Copy link
Member Author

Note: the force push was to amend the commit bump: nuxt to v2.17.2 to bump: nuxt to v2.17.3

@wesdevpro wesdevpro merged commit 1d85b6c into master Feb 13, 2024
1 check passed
@wesdevpro wesdevpro deleted the BumpBuefy branch February 13, 2024 20:04
@mirocklez
Copy link

The version is not updated yet in the NPM - can you publish it there?
https://www.npmjs.com/package/nuxt-buefy?activeTab=versions

@kikuomax
Copy link
Contributor

The version is not updated yet in the NPM - can you publish it there? https://www.npmjs.com/package/nuxt-buefy?activeTab=versions

@miroslavgeorgiev @wesdevpro GitHub Actions workflow for publishing npm package failed with:

npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
npm ERR! Missing: [email protected] from lock file

There is something wrong with package-lock.json. Removing node_modules, package-lock.json and yarn.lock, and re-running npm install did not solve the problem on my machine (M1 MacBook, Node.js v18).

I found dependencies related to [email protected] required different buffer versions:

  • @nuxt/clicrcbuffer>=6.0.3 (in peerDependencies)
  • @nuxt/webpackwebpackbarwebpacknode-libs-browserbuffer^4.3.0 (in dependencies)

Since the requirement for buffer>=6.0.3 is in peerDependencies, it is user's responsibility to install buffer>=6.0.3. As we did not explicitly install buffer>=6.0.3, we ended up with [email protected] installed.

kikuomax added a commit to kikuomax/nuxt-buefy that referenced this pull request Feb 15, 2024
- Fixes the problem that `npm ci` failed due to version mismatch of
  `buffer`. `buffer` older than required in `peerDependencies` of one
  dependency was installed because `peerDependencies` does not impose
  installation of the package. Explicitly installs `buffer^6.0.3` to
  resolve the issue. See the following comment for more details:
  buefy#151 (comment)
@mirocklez
Copy link

The version is not updated yet in the NPM - can you publish it there? https://www.npmjs.com/package/nuxt-buefy?activeTab=versions

@miroslavgeorgiev @wesdevpro GitHub Actions workflow for publishing npm package failed with:

npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
npm ERR! Missing: [email protected] from lock file

There is something wrong with package-lock.json. Removing node_modules, package-lock.json and yarn.lock, and re-running npm install did not solve the problem on my machine (M1 MacBook, Node.js v18).

I found dependencies related to [email protected] required different buffer versions:

  • @nuxt/clicrcbuffer>=6.0.3 (in peerDependencies)
  • @nuxt/webpackwebpackbarwebpacknode-libs-browserbuffer^4.3.0 (in dependencies)

Since the requirement for buffer>=6.0.3 is in peerDependencies, it is user's responsibility to install buffer>=6.0.3. As we did not explicitly install buffer>=6.0.3, we ended up with [email protected] installed.

This is really strange.
I checked our company apps - on all of them we're on Nuxt 2.17.3 and inside the package-lock file we've ended up with:

"node_modules/buffer": {
      "version": "4.9.2",
      "resolved": "https://registry.npmjs.org/buffer/-/buffer-4.9.2.tgz",
      "integrity": "sha512-xq+q3SRMOxGivLhBNaUdC64hDTQwejJ+H0T/NB1XMtTVEwNTrfFF3gAxiyW0Bu/xWEGhjVKgUcMhCrUy2+uCWg==",
      "dependencies": {
        "base64-js": "^1.0.2",
        "ieee754": "^1.1.4",
        "isarray": "^1.0.0"
      }
    },

As we've followed the same strategy as you:

  • delete node_modules folder and package-lock file
  • run npm install and no problems so far, but we lack using yarn
  • NodeJS version we use is ^20 but I doubt the problem is there

So I checked the master branch here:

  • with npm ci - I got the same error
  • if I delete package-lock, yarn.lock and node_modules, then execute first npm install then npm ci (for the github action) - it passes correct, but no yarn.lock is created (I dont use it)

I can create a PR for you to check

@kikuomax
Copy link
Contributor

@miroslavgeorgiev Thank you for investigating the error. I tried Node v20.x:

  1. I switched my Node.js to v20.11.1 (npm v10.2.4).
  2. I deleted package-loc.json, yarn.lock, and node_modules.
  3. I ran npm install.
  4. I ran npm ci.
  5. I got the same error.

We worked around the issue by explicitly installing [email protected] (#152), and nuxt-buefy v0.4.28 was successfully published. If the latest nuxt-buefy had any problem, we would appreciate your PR.

@mirocklez
Copy link

It is working now, so thank you too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants