-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include field and type name in toBinary errors? #983
Comments
Hey Ben, it would be nice to provide more context in those errors if we can avoid regressions on performance, and keep bundle size reasonable. It's not as simple as catching everything in writeField though, since it's called recursively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would folks be open to adding more information to errors returned from
toBinary
? For example, right now I'm getting this error:I can't tell which field was being written, or which message type. If we added a try/catch around writeField we could add this information. I'm happy to submit a PR if this is something folks want.
The text was updated successfully, but these errors were encountered: