Add isInf and isNan #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotmjackson
approved these changes
Aug 23, 2023
igor-tsiglyar
pushed a commit
to igor-tsiglyar/protovalidate
that referenced
this pull request
Apr 16, 2024
In some cases we want to have test cases that fail the new protovalidate lint warnings. Update the buf.yaml to exclude those lint checks from the tests. Additionally, update to the latest cel-go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out python throws an exception when you divide by zero, even for floats. So standardize test functions for both inf and nan.
This requires all impls to be updated to include the
double.isNananddouble.isInffunctions before upgrading to this version of the protos.