Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable URL caching to always get the latest data from GitHub (comments, statuses) #10

Closed
czechboy0 opened this issue Apr 26, 2015 · 1 comment
Labels

Comments

@czechboy0
Copy link
Member

The default NSURLSession's configuration respects GitHub's response TTL, which is up to 60 seconds. However, if we want to sync more often (GitHub's authenticated rate limit is 5000 requests per hour, which is plenty to make Buildasaur very responsive to the team's workflow, when the sync interval is lower, cca 15sec), currently we get the same, cached response for ~4 more syncs, leading to duplicate comments etc. We need to disable the cache to always get the uncached state of the PR (status and comments, most importantly)

@czechboy0 czechboy0 added the bug label Apr 26, 2015
@czechboy0
Copy link
Member Author

Fixed in 23d13de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant