Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove section "component" #276

Open
james-nash opened this issue May 21, 2019 · 0 comments
Open

Remove section "component" #276

james-nash opened this issue May 21, 2019 · 0 comments
Labels
ui CATEGORY: Anything related to the design or implementation of UI components and styles

Comments

@james-nash
Copy link

Is your feature request related to a problem? Please describe.
Our pattern library currently contains a section "component" under organisms. It's mot really a Gravity component since we don't have any special styling associated with the <section>, so I think listing it is a tad confusing. It also obfuscates what (actual) Gravity components the page templates use, because they all use section, but configure it to display different things.

I think this section thing orignally came about as a bit of a hack to simulate some early website design ideas within the pattern library (and also to work around some Mustache and Pattern Lab limitations/quirks we had at the time), before we were able to implement the corresponding templates in the website codebase.

Long story short, it's clunky, confusing and no longer serves a purpose. I therefore propose we nuke it from orbit.

Describe the solution you'd like

  • Kill section with fire
  • Amend sample page templates to directly include or import what they need

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@james-nash james-nash added the ui CATEGORY: Anything related to the design or implementation of UI components and styles label May 21, 2019
@james-nash james-nash added this to the Gravity NEXT milestone May 21, 2019
@james-nash james-nash removed this from the Gravity NEXT milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui CATEGORY: Anything related to the design or implementation of UI components and styles
Projects
None yet
Development

No branches or pull requests

1 participant