Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewImage constructors should allow overriding default image properties #67

Open
micahyoung opened this issue Oct 15, 2020 · 1 comment
Labels
status/ready type/enhancement New feature or request

Comments

@micahyoung
Copy link
Member

micahyoung commented Oct 15, 2020

Right now, several image parameters get set by default on a new, empty image, which can only be overridden with Set*(). It would be convenient to be able to set these in the constructor.

The most useful constructor parameters for common image config properties would be:

  • os - remote only, to override linux default
  • os.version - local/remote, for setting compatible Windows kernel version.
  • architecture - local/remote, to override amd64 default

This should also be considered along with #54 which will need a way to disambiguate manifest lists during FromBaseImage (also os, os.version, architecture, though these fields map to the manifest platform not the image config)

@micahyoung micahyoung changed the title NewImage constructors should allow overriding default OS parameters NewImage constructors should allow overriding default OS parameters Oct 15, 2020
@micahyoung micahyoung changed the title NewImage constructors should allow overriding default OS parameters NewImage constructors should allow overriding default image properties Oct 15, 2020
@natalieparellano
Copy link
Member

@micahyoung was this resolved in #91 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants