Reload config on SELinux policy load #379
Conversation
When a new SELinux policy is loaded the dbus config file it carries may have been updated as well. As such, we should reload the dbus configuration to catch any changes. This logic already exists in the dbus-daemon code and this change is largely based off of that code.
matt-sheets
force-pushed
the
matts/selinux-reload
branch
from
53ea1c4
to
f17d94e
Compare
There was a problem hiding this comment.
Thanks for the PR! Sadly, we cannot rely on the broker to have its controller as parent PID. So this either needs channeling via the controller interface, or we simply make the launcher listen for these events and trigger the reload from there (which I think is preferable).
| */ | ||
| static int policy_reload_callback(int seqno) { | ||
| pid_t ppid = getppid(); | ||
| return kill(ppid, SIGHUP); |
There was a problem hiding this comment.
The launcher/controller is not necessarily the parent PID. We need to pass this through the controller interface, just like the other activation related messages.
|
Thanks for the feedback, I am not very familiar with the broker code, so any input is more than welcome. I have tried to move the callback registration into launcher itself, but the actual callback method never seems to run. I am still digging into this but not making great progress. Could you possibly point me in the correct direction when you say "channeling via the controller interface" if setting up the callback in the launcher doesn't work out? |
When a new SELinux policy is loaded, the dbus config file it carries may have been updated as well. As such, we should reload the dbus configuration to catch any changes. This logic already exists in the dbus-daemon code and this change is largely based off of that code.