fix build error when building on XCode 8.3 #121
Conversation
|
Hi @igor-makarov, It looks like you haven't signed our Contributor License Agreement, yet.
Please read and sign our full Contributor License Agreement here. Once you've signed reply with Thank you, ButtonBot |
|
[clabot:check] |
|
@wessmith It looks like @igor-makarov just signed our Contributor License Agreement. 👍 ButtonBot |
|
whats wrong with the checks? Will it be merged today? 😄 |
|
It fails because the bundler is on CocoaPods 0.39 and it's been EOL. |
There was a problem hiding this comment.
Minor style change but otherwise seems sane -- thanks for an awesome contribution.
@ioswes can you take a look as you're the owner?
| - pod install | ||
| script: | ||
| - xctool test -workspace DeepLinkKit.xcworkspace -scheme ReceiverDemo -sdk iphonesimulator ONLY_ACTIVE_ARCH=NO | ||
| - travis_retry xcodebuild build test -workspace DeepLinkKit.xcworkspace -scheme ReceiverDemo -sdk iphonesimulator -configuration Debug -destination 'platform=iOS Simulator,name=iPhone 7,OS=latest' |
There was a problem hiding this comment.
I can't believe that exists! Haha
.travis.yml
Outdated
| branches: | ||
| only: | ||
| master | ||
| before_install: | ||
| - bundle | ||
| # - gem install xcpretty --no-rdoc --no-ri --no-document --quiet |
There was a problem hiding this comment.
Kill commented code? Tidy Travis YML file, tidy mind.
| @@ -1,5 +1,8 @@ | |||
| @import DeepLinkKit.Private; | |||
| @import DeepLinkKit.AppLinks; | |||
| #import "DPLDeepLink.h" | |||
There was a problem hiding this comment.
What prevents you importing the module here? This will still work externally, right?
There was a problem hiding this comment.
Well, you haven't got subspecs defined, so I don't see the point... CP generates an umbrella header for it all and you can do @import DeepLinkKit.AppLinks;. I updated the test to use it like that.
|
All done, please merge! |
|
@igor-makarov thanks for the fixes. @chrismaddern any estimation when this pr can be merged? |
|
Just downloaded Xcode 8.3 and needing this branch merged! |
|
Thanks for this @igor-makarov! |
wessmith
dismissed
chrismaddern’s stale review
Requested changes are corrected.
|
Awesome! Please tag out a new release for the benefit of @salabaha @yusuftor @Unihilator and also @taher-mosbah @superpeteblaze @Ekhoo from #119 |
|
Available in 1.2.2 |
Fix for #119