Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower deployment target for DeepLinkKit build target #156

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

jou
Copy link
Contributor

@jou jou commented Aug 21, 2019

The iOS deployment target for the DeepLinkKit build target was set to 10.3. When added as a dependency through Carthage, this will make apps built with lower deployment target crash when running on iOS version lower than 10.3.

This PR lowers the deployment target to 7.0, consistent with what's specified in the Podspec.

@button-bot
Copy link

Hi @jou,
Thank you for your Pull Request!

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license.
Wikipedia

Please read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to let us know.

Thank you,

ButtonBot

@jou
Copy link
Contributor Author

jou commented Aug 21, 2019

[clabot:check]

@button-bot
Copy link

@wessmith It looks like @jou just signed our Contributor License Agreement. 👍

ButtonBot

@chrismaddern chrismaddern merged commit 8541545 into button:master Aug 21, 2019
@chrismaddern
Copy link
Contributor

Thanks @jou

@wessmith can you make a new release? 😛

@jou
Copy link
Contributor Author

jou commented Aug 22, 2019

Whee! Thanks for the fast response!

@kmpnz
Copy link

kmpnz commented Aug 30, 2019

Any updates on this release @wessmith ?

@wessmith
Copy link
Member

wessmith commented Sep 9, 2019

Releases 1.5.1 is available now (1.5.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants