Fix fcntl_setpipe_size return value
#1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyyxx
force-pushed
the
main
branch
3 times, most recently
from
2342fb4
to
fb830a3
Compare
jjyyxx
changed the title
fcntl_setpipe_size return value (#1163)fcntl_setpipe_size return value
jjyyxx
force-pushed
the
main
branch
2 times, most recently
from
397a089
to
6a80c79
Compare
`fcntl` man page says that: > F_SETPIPE_SZ ... The actual capacity (in bytes) that is set is > returned as the function result. But the current `fcntl_setpipe_size` function assumes that the return value is 0 (success) or negative (failure). This makes the function panic due to `debug_assert!` in debug mode, and it returns `Err` on success in release mode. This commit fixes the return value type and its checking, and adds a test for it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcntlman page says that:But the current
fcntl_setpipe_sizefunction assumes that the return value is 0 (success) or negative (failure). This makes the function panic due todebug_assert!in debug mode, and it returnsErron success in release mode.This commit fixes the return value type and its checking, and adds a test for it.
Closes #1163