Remove naked_functions feature usage for x86 #722
Merged
+30
−695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been able to reproduce the CI issue locally. Probably need to steal the version out from CI to figure out what happened. |
sunfishcode
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Thanks! Using global_asm is much nicer than shipping a prebuilt archive.
The CI failure turned out to be an existing bug, which is now fixed in #723.
Given that this function has no generics, it could easily use `global_asm!` instead.
|
Thanks! |
sunfishcode
added a commit
that referenced
this pull request
Jul 6, 2023
rustix 0.38 removed for most of the out-of-line asm libraries, and #722 removed the out-of-line libraries for 32-bit x86. This PR removes the libraries for mips and power, which will now default to the libc backend, though the linux_raw backend can still be enabled using `RUSTFLAGS=--cfg=rustix_use_experimental_asm`. Closes #720.
sunfishcode
added a commit
that referenced
this pull request
Jul 6, 2023
rustix 0.38 removed for most of the out-of-line asm libraries, and #722 removed the out-of-line libraries for 32-bit x86. This PR removes the libraries for mips and power, which will now default to the libc backend, though the linux_raw backend can still be enabled using `RUSTFLAGS=--cfg=rustix_use_experimental_asm`. Closes #720.
sunfishcode
added a commit
that referenced
this pull request
Jul 6, 2023
rustix 0.38 removed for most of the out-of-line asm libraries, and #722 removed the out-of-line libraries for 32-bit x86. This PR removes the libraries for mips and power, which will now default to the libc backend, though the linux_raw backend can still be enabled using `RUSTFLAGS=--cfg=rustix_use_experimental_asm`. Closes #720.
sunfishcode
pushed a commit
that referenced
this pull request
Oct 13, 2024
Given that this function has no generics, it could easily use `global_asm!` instead. This is a backport of #722, except without the part that removes outline asm for x86, as that's still needed on the 0.37 branch. It fixes compilation errors on the 0.37 when compiled with the latest nightly, due to `asm!` in `#[naked]` functions needed to be change to `naked_asm!`. Fixes #1181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this function has no generics, it could easily use
global_asm!instead.