Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend configuration #151

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Add frontend configuration #151

merged 1 commit into from
Mar 24, 2020

Conversation

quite
Copy link
Contributor

@quite quite commented Mar 23, 2020

Allow configuring of:

  • time format
  • indentation of message that are wrapped on a new line

@quite
Copy link
Contributor Author

quite commented Mar 23, 2020

Hey! Here goes something :) It does not alter the current look of cabal-cli. But I do strongly prefer timeformat '%H%M' and indent time myself

@cblgh
Copy link
Member

cblgh commented Mar 23, 2020

@quite wanna leave a screenshot of what it looks like for you? :)

@quite
Copy link
Contributor Author

quite commented Mar 23, 2020

My preference:
2020-03-23-144836_1148x1047_scrot

@quite
Copy link
Contributor Author

quite commented Mar 23, 2020

A tad ugly passing around the config like that. And passing the frontendConfig et al through the state...

@cblgh
Copy link
Member

cblgh commented Mar 24, 2020

@quite yeah fuck it, let's merge this. i'll take on the responsibility of rewriting things if the config gets out of hand later :~

can update the readme so that people know this option exists? maybe a small section under Headless mode about configuring timestamps, with directions to read .cabal.yml-example for more information.

Allow configuring of:
  - time format
  - indentation of message that are wrapped on a new line
@quite
Copy link
Contributor Author

quite commented Mar 24, 2020

Done!

@cblgh cblgh merged commit a914706 into cabal-club:master Mar 24, 2020
@cblgh
Copy link
Member

cblgh commented Mar 24, 2020

💯

@quite quite deleted the frontend branch March 24, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants