-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use matched path as span name #6469
Comments
I guess the @andriikushch could you look into that, since you contributed tracing? |
It does support placeholder replacement @francislavoie ! But I'm not seeing the necessary placeholders in the |
Hmm, I was reading the code and I don't see where it gets placeholder-replaced. If you're using |
@francislavoie yes but if I'm setting up tracer on a listener, I have |
I don't understand the problem. You haven't shown your full config so I don't have any context here. |
@francislavoie here you have a sample config. In the original config the reverse_proxies are imported from individual proxies files. Sample config:
Expected span names to keep low cardinality as recommended by Otel:
Possibly what I need is something like |
I'm trying to setup Caddy as the reverse proxy for our project and everything is great so far. We have a mix o reverse_proxies that uses
path
and some that usepath_regexp
.The problem here is that, following OTel guidelines, the span name should be of low cardinality and for this I'm trying to use
{http.method} {http.route}
, where thehttp.route
if the original path matching rule like so:path:
Reverse proxy:
Expected span name:
GET /api/v1/users/login
path_regexp:
Reverse proxy:
Expected span name:
POST ^/admin/v1/users/(.*)/accounts$
Is this possible somehow? Thanks in advance.
The text was updated successfully, but these errors were encountered: