Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade template and repo to Yarn 3 #421

Merged
merged 2 commits into from
Sep 22, 2023
Merged

feat: upgrade template and repo to Yarn 3 #421

merged 2 commits into from
Sep 22, 2023

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Jul 14, 2023 •
edited
Loading

Summary

This migrates the repo and the templates to Yarn 3 from Yarn 1.

  • Yarn 1 is no longer receiving any updates or bug fixes, so it's better to move to an actively maintained version.
  • Previously the generated app was a fake monorepo that worked by overriding the yarn binary. Now it works like a regular monorepo without any hacks.

Test plan

  • Generate a native module project and make sure it builds and runs on iOS & Android
  • Make an Expo project and make sure it runs on iOS, Android & Web

@satya164 satya164 requested a review from atlj July 14, 2023 00:03
@satya164 satya164 force-pushed the @satya164/yarn-3 branch 12 times, most recently from 5608f74 to b2a45ff Compare July 14, 2023 07:20
@satya164 satya164 force-pushed the @satya164/yarn-3 branch 7 times, most recently from 74d2282 to 1826bf9 Compare September 4, 2023 04:39
@satya164 satya164 marked this pull request as ready for review September 20, 2023 17:16
atlj
atlj approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@atlj atlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and just one minor suggestion

packages/create-react-native-library/src/index.ts Show resolved Hide resolved
@satya164 satya164 merged commit f90ce89 into main Sep 22, 2023
32 checks passed
@satya164 satya164 deleted the @satya164/yarn-3 branch September 22, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlj atlj atlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satya164 @atlj